Results 1 to 3 of 3

Thread: Skonf and packs

  1. #1

    Skonf and packs

    Hi,

    I've made some packs tailored to my needs (mostly ipcams and small footprint server). Some of them have no service declared in them.
    When clicking on the "Manage packs" button in sKonf I got this
    Code:
    Traceback (most recent call last):
     File "/usr/local/shinken/shinken/webui/bottle.py", line 682, in _handle
      return callback(**args)
     File "/usr/local/shinken/shinken/webui/bottle.py", line 1332, in wrapper
      rv = callback(*a, **ka)
     File "/usr/local/shinken/shinken/daemons/skonfdaemon.py", line 673, in lock_version
      return f(**args)
     File "/usr/local/shinken/shinken/webui/bottle.py", line 2690, in wrapper
      return template(tpl_name, **tplvars)
     File "/usr/local/shinken/shinken/webui/bottle.py", line 2664, in template
      return TEMPLATES[tpl].render(kwargs)
     File "/usr/local/shinken/shinken/webui/bottle.py", line 2636, in render
      self.execute(stdout, kwargs)
     File "/usr/local/shinken/shinken/webui/bottle.py", line 2622, in execute
      eval(self.co, env)
     File "/usr/local/shinken/shinken/webui/plugins_skonf/packs/views/packs.tpl", line 69, in <module>
      <div id="services-{{tpl.get('name', '')}}" class='services_list'>
    AttributeError: 'NoneType' object has no attribute 'get'
    To fix this I just added an if clause at line 68:
    Code:
    66    <div class='span10'>
     67    %for _t in lst:
     68     %if len(services) != 0:
     69      %(tpl, services) = _t
     70  <div id="services-{{tpl.get('name', '')}}" class='services_list'>
     71     %if len(services) == 0:
     72   <div class="alert">No services enabled for this pack</div>
    And now it seems to be working ok...

    Also found another one, in "shinken/webui/plugins_skonf/packs/views/packs.tpl" at line 50 and 80. I had 404s when clicking on a service inside a pack. "elements" was written "elemments". Once corrected it works ok !


  2. #2
    Administrator
    Join Date
    Dec 2011
    Posts
    278

    Re: Skonf and packs

    Thanks for reporting.

    All three fixes, and two more in hostd were commited.

    Cheers,

    xkilian

  3. #3
    Shinken project leader
    Join Date
    May 2011
    Location
    Bordeaux (France)
    Posts
    2,130

    Re: Skonf and packs

    Thanks
    No direct support by personal message. Please open a thread so everyone can see the solution

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •